chore: docker compose to standalone by default #13814
Conversation
huangjw806
requested review from
lmatz,
neverchanje,
StrikeW,
fuyufjh,
tabVersion,
xiangjinwu and
xxhZs
|
"Doris Sink" is because we need to ensure that the entire cluster adopts the same set of network IP, otherwise it will result in RW being unable to access Doris. Is there any other way to solve the whole problem? The Feature Store needs to transfer UDF files to Docker, and I'm not sure if there is any other solution. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13814 +/- ##
=======================================
Coverage 68.23% 68.24%
=======================================
Files 1525 1525
Lines 262188 262175 -13
=======================================
+ Hits 178899 178912 +13
+ Misses 83289 83263 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
standalone mode integration test： It seems that the data check of vector case fails in standalone mode. Please help to check. cc @neverchanje |
| @@ -28,56 +28,56 @@ services: | |||
| ipv4_address: 172.21.0.3 | |||
| compactor-0: | |||
| extends: | |||
| file: ../../docker/docker-compose.yml | |||
| file: ../../docker/docker-compose-minio.yml | |||
There was a problem hiding this comment.
why didn't you use the standalone mode for this test?
There was a problem hiding this comment.
As mentioned above, I am not sure how to run it using standalone for doris-sink and feature-store.
#13814 (comment)
|
Did you run it using the nightly version? I ran on the nightly last time. |
These two cases are not in the daily test list. We can temporarily not enable standalone mode in this PR. Maybe you can try to see if you can run them in standalone mode? |
I use ‘nightly-20231205’ version |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
After testing, the standalone mode has become relatively stable, so we plan to change docker-compose to standalone by default.
docker-compose.yml->docker-compose-minio.ymldocker-compose-standalone.yml->docker-compose.ymlchange integration tests docker-compose to standalone mode. The following two cases cannot be simply changed to standalone mode, so I will still deploy using a distributed cluster.
@xxhZs please help confirm if these two cases can be run in standalone mode.
#13235
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.