fix(storage): fix compactor sst switch condition #13790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxa21
reviewed
Dec 4, 2023
src/common/src/config.rs
Outdated
| /// The spill threshold for mem table. | ||
| #[serde(default = "default::storage::mem_table_spill_threshold")] | ||
| pub mem_table_spill_threshold: usize, | ||
|
|
||
| #[serde(default)] | ||
| pub object_store: ObjectStoreConfig, | ||
|
|
||
| #[serde(default)] | ||
| pub compactor: CompactorConfig, |
There was a problem hiding this comment.
This seems to be a breaking change. For example, if user defines the config previously via:
[storage]
compactor_max_task_multiplier=4
This config will become invalid and user needs to change it toml to:
[storage.compactor]
compactor_max_task_multiplier=4
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13790 +/- ##
=======================================
Coverage 68.23% 68.23%
=======================================
Files 1524 1524
Lines 262203 262210 +7
=======================================
+ Hits 178904 178911 +7
Misses 83299 83299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hzxa21
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
2. refine compactor configrelated to #13773
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.