Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdc): add cdc backfill grafana metrics #13777

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Dec 4, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

image

close #13177

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@StrikeW StrikeW requested a review from hzxa21 December 4, 2023 04:13
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a73d940) 68.19% compared to head (3ea305f) 68.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13777   +/-   ##
=======================================
  Coverage   68.19%   68.19%           
=======================================
  Files        1524     1524           
  Lines      262232   262250   +18     
=======================================
+ Hits       178829   178847   +18     
  Misses      83403    83403           
Flag Coverage Δ
rust 68.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StrikeW StrikeW added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit a033c30 Dec 4, 2023
26 of 27 checks passed
@StrikeW StrikeW deleted the siyuan/cdc-backfill-metrics branch December 4, 2023 04:58
StrikeW added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: introduce a new metrics for cdc_backfill
2 participants