-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(udf): support struct[] type in struct #13689
Conversation
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
d349ca8
to
f627a88
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13689 +/- ##
==========================================
- Coverage 68.28% 68.25% -0.03%
==========================================
Files 1523 1523
Lines 261481 261505 +24
==========================================
- Hits 178555 178493 -62
- Misses 82926 83012 +86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Runji Wang <[email protected]>
|
||
### Changed | ||
|
||
- Change the default struct field name to `f{i}`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to change this 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's postgres' default name.
postgres=# select (row(1, 2)).*;
f1 | f2
----+----
1 | 2
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR fixes the bug that UDF doesn't support struct[] type in struct.
On RisingWave side:
On Python side:
struct<struct<int>>
On Java side:
Checklist
./risedev check
(or alias,./risedev c
)Documentation