Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: trigger auto dump by system memory usage #13685

Merged
merged 8 commits into from
Nov 28, 2023

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Nov 28, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Use system memory provided by resource_util::memory::total_memory_used_bytes() instead of jemalloc statistics for more accurate auto dump triggering.

Follow-up of #13495 especially #13495 (comment).

By the way, rename src/common/src/monitor/process_linux.rs -> process.rs

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh changed the title refactor: use system memory usage for auto dump refactor: trigger auto dump by system memory usage Nov 28, 2023
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/common/heap_profiling/src/profiler.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@yuhao-su yuhao-su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyufjh fuyufjh enabled auto-merge November 28, 2023 07:44
@fuyufjh fuyufjh added this pull request to the merge queue Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (9c752e0) 68.30% compared to head (cca8cbb) 68.31%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/common/heap_profiling/src/profiler.rs 0.00% 28 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13685   +/-   ##
=======================================
  Coverage   68.30%   68.31%           
=======================================
  Files        1523     1523           
  Lines      261707   261693   -14     
=======================================
+ Hits       178768   178781   +13     
+ Misses      82939    82912   -27     
Flag Coverage Δ
rust 68.31% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 92a624a Nov 28, 2023
26 of 27 checks passed
@fuyufjh fuyufjh deleted the eric/use_system_rss_for_auto_dump branch November 28, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants