feat: support multiple sinks into table #13659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
shanicky
force-pushed
the
peng/multi-sink-into
branch
from
91de787 to
dfe4e5e
Compare
shanicky
commented
Nov 29, 2023
| for input in &mut node.input { | ||
| if let Some(NodeBody::Merge(merge_node)) = &mut input.node_body && merge_node.upstream_actor_id.is_empty() { | ||
| if let Some(sink_id) = sink_id { | ||
| input.identity = format!("MergeExecutor(from sink {})", sink_id); |
There was a problem hiding this comment.
we can assign identity of Merger at here cc @st1page
shanicky
force-pushed
the
peng/sink-into-table-new
branch
from
3fd4a57 to
d28527a
Compare
shanicky
force-pushed
the
peng/multi-sink-into
branch
2 times, most recently
from
27f3117 to
84af28f
Compare
shanicky
force-pushed
the
peng/sink-into-table-new
branch
from
f07654d to
b160d0b
Compare
shanicky
force-pushed
the
peng/multi-sink-into
branch
from
84af28f to
405e764
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13659 +/- ##
==========================================
- Coverage 68.06% 68.03% -0.04%
==========================================
Files 1535 1535
Lines 264826 264925 +99
==========================================
- Hits 180266 180234 -32
- Misses 84560 84691 +131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shanicky
force-pushed
the
peng/multi-sink-into
branch
from
405e764 to
3f1e744
Compare
shanicky
force-pushed
the
peng/sink-into-table-new
branch
from
1478dd3 to
0a05844
Compare
shanicky
force-pushed
the
peng/multi-sink-into
branch
from
3f1e744 to
e7da583
Compare
shanicky
force-pushed
the
peng/multi-sink-into
branch
from
e7da583 to
821e49a
Compare
…oming sinks in handle_create_sink Implement e2e test for error messages, sink creation, table alteration, query sorting, sink and table dropping. Code changes: Imports, function rename, argument modifications, variable rename, new arguments. fix conflict tmp Signed-off-by: Shanicky Chen <[email protected]>
Signed-off-by: Shanicky Chen <[email protected]>
shanicky
force-pushed
the
peng/multi-sink-into
branch
from
821e49a to
2390232
Compare
BugenZhao
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
For creation, we will re-create the table with n additional merges and connect it to the existing (obtained through TableFragments from fragment manager) and newly built sink’s dispatcher in the meta node.
For dropping, we will re-create the table with n-1 additional merges on the meta node, connect it only with the dispatchers of the other sinks.
Checklist
./risedev check(or alias,./risedev c)