Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): improve index selection for primary lookup #13658

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Nov 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a3ea7c0) 68.18% compared to head (6b08e90) 68.19%.
Report is 2 commits behind head on main.

Files Patch % Lines
...rontend/src/optimizer/rule/index_selection_rule.rs 82.14% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13658   +/-   ##
=======================================
  Coverage   68.18%   68.19%           
=======================================
  Files        1521     1521           
  Lines      261709   261724   +15     
=======================================
+ Hits       178459   178470   +11     
- Misses      83250    83254    +4     
Flag Coverage Δ
rust 68.19% <82.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenzl25 chenzl25 added this pull request to the merge queue Nov 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 27, 2023
@chenzl25 chenzl25 added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit 9768a72 Nov 27, 2023
30 of 31 checks passed
@chenzl25 chenzl25 deleted the dylan/improve_index_selection_for_primary_lookup branch November 27, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants