Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename props with dot separation #13656

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

rename scan.startup.timestamp_millis to scan.startup.timestamp.millis for unifying naming manner

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

please rename scan.startup.timestamp_millis to scan.startup.timestamp.millis for kafka, pulsar and nats source

there wont be compatibility issue.

@tabVersion tabVersion enabled auto-merge December 7, 2023 08:19
@tabVersion tabVersion added this pull request to the merge queue Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (744df85) 68.30% compared to head (fd19b41) 68.31%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13656   +/-   ##
=======================================
  Coverage   68.30%   68.31%           
=======================================
  Files        1528     1528           
  Lines      262669   262669           
=======================================
+ Hits       179425   179440   +15     
+ Misses      83244    83229   -15     
Flag Coverage Δ
rust 68.31% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 57cc9b9 Dec 7, 2023
26 of 27 checks passed
@tabVersion tabVersion deleted the tab/fix-kafka-startup-mode branch December 7, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants