Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update to new github note syntax #13646

Merged
merged 1 commit into from
Nov 27, 2023
Merged

doc: update to new github note syntax #13646

merged 1 commit into from
Nov 27, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Nov 24, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

https://github.com/orgs/community/discussions/16925

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the component/doc Issues about documentation. label Nov 24, 2023
@xxchan xxchan enabled auto-merge November 24, 2023 14:49
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the change

@xxchan xxchan added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit f92b501 Nov 27, 2023
11 of 12 checks passed
@xxchan xxchan deleted the xxchan/homely-monkey branch November 27, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/doc Issues about documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants