Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streaming): use correct label for stream_fragment_exchange_bytes metrics #13644

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix(streaming): use correct label for stream_fragment_exchange_bytes metrics #13644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/compute/src/rpc/service/exchange_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,12 @@ impl ExchangeService for ExchangeServiceImpl {
let mut request_stream: Streaming<GetStreamRequest> = request.into_inner();

// Extract the first `Get` request from the stream.
let get_req = {
let Get {
up_actor_id,
down_actor_id,
up_fragment_id,
down_fragment_id,
} = {
let req = request_stream
.next()
.await
Expand All @@ -94,8 +99,10 @@ impl ExchangeService for ExchangeServiceImpl {
}
};

let up_down_actor_ids = (get_req.up_actor_id, get_req.down_actor_id);
let receiver = self.stream_mgr.take_receiver(up_down_actor_ids).await?;
let receiver = self
.stream_mgr
.take_receiver((up_actor_id, down_actor_id))
.await?;

// Map the remaining stream to add-permits.
let add_permits_stream = request_stream.map_ok(|req| match req.value.unwrap() {
Expand All @@ -108,7 +115,7 @@ impl ExchangeService for ExchangeServiceImpl {
peer_addr,
receiver,
add_permits_stream,
up_down_actor_ids,
(up_fragment_id, down_fragment_id),
)))
}
}
Expand Down
Loading