Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): record inject or collect barrier failure in event table #13624

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Nov 23, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR makes meta node record the error encountered during injecting or collecting barrier in the event log table.

Note that the new sim test should be flaky, but according to my test results, it's stable.

#12827

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (f707c5f) 68.21% compared to head (d65f99c) 68.20%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/meta/src/barrier/mod.rs 30.00% 21 Missing ⚠️
src/stream/src/executor/actor.rs 25.00% 3 Missing ⚠️
...catalog/system_catalog/rw_catalog/rw_event_logs.rs 0.00% 2 Missing ⚠️
src/meta/src/manager/event_log.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13624      +/-   ##
==========================================
- Coverage   68.21%   68.20%   -0.01%     
==========================================
  Files        1520     1520              
  Lines      261556   261592      +36     
==========================================
+ Hits       178410   178427      +17     
- Misses      83146    83165      +19     
Flag Coverage Δ
rust 68.20% <26.31%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	proto/meta.proto
#	src/frontend/src/catalog/system_catalog/rw_catalog/rw_event_logs.rs
#	src/meta/src/manager/event_log.rs
@zwang28 zwang28 enabled auto-merge November 24, 2023 06:40
@zwang28 zwang28 added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 0d5bf77 Nov 24, 2023
28 of 29 checks passed
@zwang28 zwang28 deleted the wangzheng/barrier_event branch November 24, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants