Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector): add kafka-cdc-sink compatible test #13607

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

xuefengze
Copy link
Contributor

@xuefengze xuefengze commented Nov 23, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In Risingwave -(Debezium Json)-> Kafka -(Debezium Json)-> JDBC connector -> Postgresql pipeline:

In Risingwave -(Debezium Json)-> Kafka -(Debezisum Json)-> Flink SQL --> Postgresql pipeline:
According to Flink, support types: boolean, smallint, integer, bigint, decimal, real, double precision, varchar, bytea.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xuefengze xuefengze requested a review from lmatz November 23, 2023 03:25
@github-actions github-actions bot added the component/test Test related issue. label Nov 23, 2023
@xuefengze xuefengze requested a review from cyliu0 November 23, 2023 03:26
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lmatz lmatz enabled auto-merge November 23, 2023 03:34
@lmatz lmatz disabled auto-merge November 23, 2023 04:47
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8deba24) 68.15% compared to head (5630ae1) 68.14%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13607      +/-   ##
==========================================
- Coverage   68.15%   68.14%   -0.01%     
==========================================
  Files        1513     1513              
  Lines      261013   261013              
==========================================
- Hits       177892   177877      -15     
- Misses      83121    83136      +15     
Flag Coverage Δ
rust 68.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmatz lmatz added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit e2f7fdb Nov 23, 2023
30 of 31 checks passed
@lmatz lmatz deleted the fengze/kafka-compatibility-test branch November 23, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants