Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove mem table memory metrics #13604

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Nov 23, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As mem table is spillable, the memory usage of it is unused.

Resolves #13595

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu requested a review from fuyufjh November 23, 2023 02:49
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I slightly tend to keep such metrics just in case. But considering this implementation looks heavy, it's okay to me to just remove it.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Nov 23, 2023

Actually I slightly tend to keep such metrics just in case. But considering this implementation looks heavy, it's okay to me to just remove it.

At first I had similar thoughts, but I realized that this(histogram) metrcis is hardly observable under normal circumstances, and when barrier stuck, mem table will spill, so I decided to remove it.

@wcy-fdu wcy-fdu enabled auto-merge November 23, 2023 03:04
@wcy-fdu wcy-fdu added this pull request to the merge queue Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3eecb3) 68.16% compared to head (7977a5a) 68.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13604      +/-   ##
==========================================
- Coverage   68.16%   68.10%   -0.07%     
==========================================
  Files        1512     1512              
  Lines      261162   261144      -18     
==========================================
- Hits       178034   177854     -180     
- Misses      83128    83290     +162     
Flag Coverage Δ
rust 68.10% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 53c5250 Nov 23, 2023
27 of 28 checks passed
@wcy-fdu wcy-fdu deleted the wcy/remove_mem_table_metrics branch November 23, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce metrics of state_store_mem_table to fragment-level
2 participants