fix: ALTER xxx OWNER TO xxx should check the CREATE privilege on the schema

[Rossil2012]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #13509.

psql -h localhost -p 4566 -d dev -U root
create user test1;
create user test2;
psql -h localhost -p 4566 -d dev -U test1
create table t(id int);
alter table t owner to test2;
# ERROR:  QueryError
# Caused by:
#  Permission denied: Require new owner to have create privilege on the object
psql -h localhost -p 4566 -d dev -U root
grant create on schema public TO test2;
psql -h localhost -p 4566 -d dev -U test1
alter table t owner to test2;
# ALTER_TABLE

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[Rossil2012]

It is weird that test1/test2 does not has create privilege on dev.public schema whereas they can create table on it :)

[yezizp2012]

It is weird that test1/test2 does not has create privilege on dev.public schema whereas they can create table on it :)

Because public is writable for all users. 😄

risingwave/src/frontend/src/session.rs

Lines 717 to 723 in bcf7579

	if schema.name() != DEFAULT_SCHEMA_NAME {
	self.check_privileges(&[ObjectCheckItem::new(
	schema.owner(),
	AclMode::Create,
	Object::SchemaId(schema.id()),
	)])?;
	}

[Rossil2012]

It is weird that test1/test2 does not has create privilege on dev.public schema whereas they can create table on it :)

Because public is writable for all users. 😄

risingwave/src/frontend/src/session.rs

Lines 717 to 723 in bcf7579

	if schema.name() != DEFAULT_SCHEMA_NAME {
	self.check_privileges(&[ObjectCheckItem::new(
	schema.owner(),
	AclMode::Create,
	Object::SchemaId(schema.id()),
	)])?;
	}

Is it designed for RW? I found in PG a user still needs create privilege to create a table in public schema.

[codecov]

Codecov Report

Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (38a78d8) 68.06% compared to head (20340e6) 68.03%.
Report is 5 commits behind head on main.

Files	Patch %	Lines
src/frontend/src/handler/alter_owner.rs	0.00%	87 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13593      +/-   ##
==========================================
- Coverage   68.06%   68.03%   -0.03%     
==========================================
  Files        1516     1516              
  Lines      261570   261607      +37     
==========================================
- Hits       178049   177997      -52     
- Misses      83521    83610      +89     

Flag	Coverage Δ
rust	68.03% <1.13%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yezizp2012]

Can we add some e2e tests for it?
For example altering a table's owner which is under a non-public schema To see if it will be rejected. And altering again after granted CREATE privilege of the schema to see if it will success.

[yezizp2012]

It is weird that test1/test2 does not has create privilege on dev.public schema whereas they can create table on it :)

Because public is writable for all users. 😄

risingwave/src/frontend/src/session.rs

Lines 717 to 723 in bcf7579

	if schema.name() != DEFAULT_SCHEMA_NAME {
	self.check_privileges(&[ObjectCheckItem::new(
	schema.owner(),
	AclMode::Create,
	Object::SchemaId(schema.id()),
	)])?;
	}

Is it designed for RW? I found in PG a user still needs create privilege to create a table in public schema.

I think that's because RW don't have role concept and PUBLIC role, so we simply allow all new created user to have CREATE privilege on it.

[yezizp2012]

Rest LGTM.