fix(optimizer): do not push temporal filter predicate passing the temporal join #13549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13549 +/- ##
==========================================
- Coverage 68.23% 68.17% -0.06%
==========================================
Files 1525 1525
Lines 262188 262175 -13
==========================================
- Hits 178899 178750 -149
- Misses 83289 83425 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
st1page
commented
Dec 5, 2023
| @@ -188,56 +188,6 @@ impl LogicalJoin { | |||
| self.output_indices() == &(0..self.internal_column_num()).collect_vec() | |||
| } | |||
|
|
|||
| /// Try to split and pushdown `predicate` into a join's left/right child or the on clause. | |||
There was a problem hiding this comment.
no caller call it and it is a dead code before this PR.
chenzl25
approved these changes
Dec 5, 2023
src/frontend/planner_test/tests/testdata/input/temporal_filter.yaml
Outdated
Show resolved
Hide resolved
…om:risingwavelabs/risingwave into sts/fix_temporal_filter_predicate_pushdown
st1page
added a commit
that referenced
this pull request
Dec 5, 2023
…poral join (#13549) (#13813) Co-authored-by: stonepage <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #13412
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.