Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): workaround avro date default #13530

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolves #13505, a bug in upstream apache_avro crate that logical type date cannot parse its default.

The actual fix is at risingwavelabs/avro@d0846a1

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xiangjinwu xiangjinwu requested a review from a team as a code owner November 20, 2023 15:42
@github-actions github-actions bot added the type/fix Bug fix label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e5477a) 68.36% compared to head (2d8ed19) 68.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13530   +/-   ##
=======================================
  Coverage   68.36%   68.37%           
=======================================
  Files        1511     1511           
  Lines      259769   259769           
=======================================
+ Hits       177580   177605   +25     
+ Misses      82189    82164   -25     
Flag Coverage Δ
rust 68.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we contribute it back to the Avro official repo?

@xiangjinwu
Copy link
Contributor Author

Can we contribute it back to the Avro official repo?

Specific to this issue: This may not be the right fix, so I used the word "workaround".

General to other avro issues: Yes, and we will have to. The official rust implementation is far behind the specification and other language implementations (eg Java).

@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit b720609 Nov 21, 2023
9 of 10 checks passed
@xiangjinwu xiangjinwu deleted the fix-source-avro-date-default branch November 21, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: avro schema with default value for date cannot be parsed
4 participants