Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): use only StreamTableScan actors on recovery to track progress #13529

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

kwannoel
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Cherry picking #13498

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel requested a review from a team as a code owner November 20, 2023 12:58
@kwannoel kwannoel requested a review from lmatz November 20, 2023 12:58
@kwannoel kwannoel changed the base branch from main to v1.4-rc November 20, 2023 12:59
@github-actions github-actions bot added the type/fix Bug fix label Nov 20, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v1.4-rc@38d6d2a). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             v1.4-rc   #13529   +/-   ##
==========================================
  Coverage           ?   68.06%           
==========================================
  Files              ?     1515           
  Lines              ?   257262           
  Branches           ?        0           
==========================================
  Hits               ?   175100           
  Misses             ?    82162           
  Partials           ?        0           
Flag Coverage Δ
rust 68.06% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmatz lmatz merged commit 97eb91c into v1.4-rc Nov 21, 2023
25 of 26 checks passed
@lmatz lmatz deleted the kwannoel/fix-background-ddl branch November 21, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants