Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(jsonb): enable more jsonb regress tests #13517

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR enables more jsonb regress tests after #13229 fixed literal parsing and struct display.

To pass the test, this PR also:

  1. enables = and <> for jsonb type.
  2. enables jsonb_concat function by name.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

@github-actions github-actions bot added the component/test Test related issue. label Nov 20, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 517 lines in your changes are missing coverage. Please review.

Comparison is base (85626f4) 68.23% compared to head (6e74b77) 68.30%.
Report is 24 commits behind head on main.

Files Patch % Lines
src/compute/src/memory/controller.rs 0.00% 87 Missing ⚠️
src/object_store/src/object/s3.rs 0.00% 50 Missing ⚠️
src/compute/src/memory/manager.rs 0.00% 48 Missing ⚠️
...log/rw_catalog/rw_hummock_compact_task_progress.rs 0.00% 35 Missing ⚠️
src/expr/impl/src/aggregate/general.rs 61.11% 28 Missing ⚠️
src/frontend/src/binder/expr/function.rs 35.29% 22 Missing ⚠️
src/object_store/src/object/mod.rs 46.87% 17 Missing ⚠️
src/frontend/src/expr/agg_call.rs 11.76% 15 Missing ⚠️
src/meta/service/src/hummock_service.rs 0.00% 14 Missing ⚠️
src/frontend/src/binder/expr/mod.rs 10.00% 9 Missing ⚠️
... and 64 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13517      +/-   ##
==========================================
+ Coverage   68.23%   68.30%   +0.06%     
==========================================
  Files        1521     1523       +2     
  Lines      261770   261808      +38     
==========================================
+ Hits       178621   178827     +206     
+ Misses      83149    82981     -168     
Flag Coverage Δ
rust 68.30% <52.74%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangrunji0408

This comment was marked as resolved.

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit a5a9c98 Nov 29, 2023
28 of 29 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/jsonb-regress-test branch November 29, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants