Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datagen): generalize TimestampField to ChronoField #13439

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In preparation for timestamptz support #8550, we refactor the existing TimestampField generator (without time zone) to a generic one ChronoField. This PR intends to be a pure equivalent refactor without any new feature / bug fix.

The handling logic of basetime and max_past_mode has also been simplified.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (48bf62e) 67.72% compared to head (12988d5) 67.66%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/common/src/field_generator/timestamp.rs 92.59% 2 Missing ⚠️
src/connector/src/source/datagen/source/reader.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13439      +/-   ##
==========================================
- Coverage   67.72%   67.66%   -0.07%     
==========================================
  Files        1528     1528              
  Lines      260548   260555       +7     
==========================================
- Hits       176447   176292     -155     
- Misses      84101    84263     +162     
Flag Coverage Δ
rust 67.66% <89.65%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2023
@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit a624936 Nov 15, 2023
28 of 29 checks passed
@xiangjinwu xiangjinwu deleted the refactor-datagen-chrono branch November 15, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants