Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn off more test targets #13427

Merged
merged 11 commits into from
Nov 16, 2023
Merged

chore: turn off more test targets #13427

merged 11 commits into from
Nov 16, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Nov 14, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#12950 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b1950e) 67.82% compared to head (993b4fd) 68.45%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13427      +/-   ##
==========================================
+ Coverage   67.82%   68.45%   +0.62%     
==========================================
  Files        1528     1501      -27     
  Lines      260875   258476    -2399     
==========================================
  Hits       176951   176951              
+ Misses      83924    81525    -2399     
Flag Coverage Δ
rust 68.45% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xxchan xxchan changed the title ignore me chore: turn off more test targets Nov 15, 2023
@xxchan
Copy link
Member Author

xxchan commented Nov 15, 2023

image Why these are still here. Confusing

https://doc.rust-lang.org/cargo/reference/cargo-targets.html#integration-tests

Binary targets are automatically built if there is an integration test. This allows an integration test to execute the binary

rust-lang/cargo#7958

There is not currently a way to skip building the binaries.

Nooooooo

@xxchan xxchan marked this pull request as ready for review November 15, 2023 09:54
@xxchan
Copy link
Member Author

xxchan commented Nov 15, 2023

current main: 1615 tests. not changed

@xxchan xxchan requested a review from BugenZhao November 15, 2023 14:25
@xxchan xxchan added this pull request to the merge queue Nov 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 15, 2023
@xxchan xxchan added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit fb7fa70 Nov 16, 2023
27 of 28 checks passed
@xxchan xxchan deleted the xxchan/ut branch November 16, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants