Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): fix ctrl c cancels streaming job #13415

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Nov 14, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Seems like this has a separate path from CANCEL JOBS.

Thanks for this fix.

@chenzl25 chenzl25 enabled auto-merge November 14, 2023 10:29
@chenzl25 chenzl25 added this pull request to the merge queue Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (cde91a0) 67.86% compared to head (f071173) 67.87%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/meta/src/manager/catalog/database.rs 0.00% 11 Missing ⚠️
src/meta/src/manager/catalog/mod.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13415      +/-   ##
==========================================
+ Coverage   67.86%   67.87%   +0.01%     
==========================================
  Files        1526     1526              
  Lines      260047   260062      +15     
==========================================
+ Hits       176468   176511      +43     
+ Misses      83579    83551      -28     
Flag Coverage Δ
rust 67.87% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 2df34ee Nov 14, 2023
26 of 27 checks passed
@chenzl25 chenzl25 deleted the dylan/fix_ctrl_c_cancel_streaming_job branch November 14, 2023 11:03
@fuyufjh fuyufjh added the user-facing-changes Contains changes that are visible to users label Nov 15, 2023
@hengm3467
Copy link
Contributor

@chenzl25 Is it Ctrl+C on both Windows and Mac keyboards?

@chenzl25
Copy link
Contributor Author

@chenzl25 Is it Ctrl+C on both Windows and Mac keyboards?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: control c fails to cancel streaming job
5 participants