-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(meta): fix ctrl c cancels streaming job #13415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Seems like this has a separate path from CANCEL JOBS
.
Thanks for this fix.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13415 +/- ##
==========================================
+ Coverage 67.86% 67.87% +0.01%
==========================================
Files 1526 1526
Lines 260047 260062 +15
==========================================
+ Hits 176468 176511 +43
+ Misses 83579 83551 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@chenzl25 Is it Ctrl+C on both Windows and Mac keyboards? |
Yes. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
in_progress_creation_streaming_job
and tables in the database manager could contain creating streaming jobs. We need to check them together.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.