Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sink): change debezium json bytea type encoder #13404

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

xuefengze
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #13327

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@lmatz lmatz requested a review from xiangjinwu November 14, 2023 06:26
@xiangjinwu
Copy link
Contributor

xiangjinwu commented Nov 14, 2023

  • The check > cargo audit failure has been fixed in main, just rebase/merge main
  • I am not familiar with the end-to-end test (parallel) > e2e_test/visibility_mode/barrier.slt failure
  • Update tests on bytea as in fix: wrong ts_ms field in debezium json #13391?

@xuefengze
Copy link
Contributor Author

* Update tests on `bytea` as in [fix: wrong ts_ms field in debezium json #13391](https://github.com/risingwavelabs/risingwave/pull/13391)?

There were no tests on bytea in e2e_test/sink/kafka originally, I have added relevant tests.

@xuefengze xuefengze added this pull request to the merge queue Nov 15, 2023
Merged via the queue into risingwavelabs:main with commit 9ca614a Nov 15, 2023
5 of 6 checks passed
@xuefengze xuefengze deleted the fix_debezium_bytea branch November 15, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka-cdc-sink bytea type dosen't work with JDBC connector
3 participants