Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix memory limit suffix in docker compose #13382

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

huangjw806
Copy link
Contributor

@huangjw806 huangjw806 commented Nov 13, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix (https://buildkite.com/risingwavelabs/integration-tests/builds/335) caused by[#13343 ]

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

@huangjw806 huangjw806 requested review from lmatz and fuyufjh November 13, 2023 08:25
@github-actions github-actions bot added the type/fix Bug fix label Nov 13, 2023
@huangjw806 huangjw806 requested a review from xuefengze November 13, 2023 08:26
@huangjw806 huangjw806 enabled auto-merge November 13, 2023 08:32
@huangjw806 huangjw806 added this pull request to the merge queue Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #13382 (b005f22) into main (b10238c) will decrease coverage by 0.07%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13382      +/-   ##
==========================================
- Coverage   67.84%   67.78%   -0.07%     
==========================================
  Files        1526     1526              
  Lines      259835   259835              
==========================================
- Hits       176290   176128     -162     
- Misses      83545    83707     +162     
Flag Coverage Δ
rust 67.78% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Merged via the queue into main with commit a962e0a Nov 13, 2023
30 of 31 checks passed
@huangjw806 huangjw806 deleted the jianwei/fix-memory-limit branch November 13, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants