Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compaction test open enable_test_epoch flag #13359

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Nov 10, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #13358

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #13359 (953f149) into main (4c78170) will decrease coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13359      +/-   ##
==========================================
- Coverage   67.76%   67.76%   -0.01%     
==========================================
  Files        1525     1525              
  Lines      259619   259619              
==========================================
- Hits       175934   175932       -2     
- Misses      83685    83687       +2     
Flag Coverage Δ
rust 67.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does enable_test_epoch do?

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Nov 10, 2023

What does enable_test_epoch do?

After mem table is spillable, we do some sanity check to make sure the last 16 bit of epoch is 0, while some unit tests use randomly written epoch, so enable_test_epoch is to disable this check.

@wcy-fdu wcy-fdu added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 205fbf9 Nov 10, 2023
9 of 10 checks passed
@wcy-fdu wcy-fdu deleted the wcy/fix_delete_range branch November 10, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic during delete-range-test-ci-release
2 participants