Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(error): show pretty error in planner test #13348

Merged
merged 10 commits into from
Nov 10, 2023

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After #13264, we print the error sources in PSQL. This PR does the similar stuff for the planner tests.

Also replaced the manual "Cause by" with the source chain. https://github.com/risingwavelabs/risingwave/pull/13348/files#diff-70784a30f4693fe9ecb89ad1b84a60d39562589d2ae378aae9767e0187d64ab3

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao requested a review from a team as a code owner November 9, 2023 12:19
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao requested a review from xxchan November 10, 2023 05:25
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #13348 (9f5a034) into main (8004505) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main   #13348      +/-   ##
==========================================
+ Coverage   67.74%   67.81%   +0.06%     
==========================================
  Files        1525     1525              
  Lines      259554   259521      -33     
==========================================
+ Hits       175842   175983     +141     
+ Misses      83712    83538     -174     
Flag Coverage Δ
rust 67.81% <66.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/src/error.rs 54.91% <ø> (ø)
src/frontend/src/binder/expr/mod.rs 69.54% <100.00%> (-1.94%) ⬇️
src/utils/pgwire/src/pg_message.rs 64.50% <0.00%> (ø)
src/frontend/planner_test/src/lib.rs 87.52% <60.00%> (ø)

... and 19 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@BugenZhao BugenZhao added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit e71d94f Nov 10, 2023
7 of 8 checks passed
@BugenZhao BugenZhao deleted the bz/planner-test-pretty-error branch November 10, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants