Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): add opentelemetry group #13303

Merged
merged 4 commits into from
Nov 15, 2023
Merged

chore(dependabot): add opentelemetry group #13303

merged 4 commits into from
Nov 15, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Nov 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested a review from TennyZhuang November 8, 2023 01:56
@xxchan xxchan enabled auto-merge November 8, 2023 01:56
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tracing-opentelemetry?

@xxchan
Copy link
Member Author

xxchan commented Nov 8, 2023

I think they are not maintained together, but yes we can put them in a group 🤣

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a624936) 67.76% compared to head (268c826) 68.08%.

❗ Current head 268c826 differs from pull request most recent head 827f935. Consider uploading reports for the commit 827f935 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13303      +/-   ##
==========================================
+ Coverage   67.76%   68.08%   +0.31%     
==========================================
  Files        1528     1522       -6     
  Lines      260882   258130    -2752     
==========================================
- Hits       176796   175737    -1059     
+ Misses      84086    82393    -1693     
Flag Coverage Δ
rust 68.08% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BugenZhao
Copy link
Member

I think they are not maintained together, but yes we can put them in a group 🤣

Yeah, but there's a version requirement. 😄 We need to pass a structure from one crate to another, where the versions have to match each other.

@xxchan xxchan requested a review from BugenZhao November 15, 2023 08:57
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have I approved an exactly identical PR before?

@xxchan xxchan added this pull request to the merge queue Nov 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2023
@xxchan xxchan enabled auto-merge November 15, 2023 11:45
@xxchan xxchan added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 4e16834 Nov 15, 2023
7 of 8 checks passed
@xxchan xxchan deleted the xxchan/xenial-jay branch November 15, 2023 12:30
@BugenZhao
Copy link
Member

Have I approved an exactly identical PR before?

Oh, it is this PR. 🤡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants