Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: report stream chunk size as partition_input_bytes for workload generator #13284

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #12278

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #13284 (11d72ce) into main (e3c8649) will increase coverage by 0.07%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13284      +/-   ##
==========================================
+ Coverage   68.00%   68.07%   +0.07%     
==========================================
  Files        1521     1521              
  Lines      257858   257863       +5     
==========================================
+ Hits       175364   175552     +188     
+ Misses      82494    82311     -183     
Flag Coverage Δ
rust 68.07% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/connector/src/source/monitor/metrics.rs 95.23% <ø> (ø)
src/connector/src/source/nexmark/source/reader.rs 95.91% <100.00%> (+0.21%) ⬆️

... and 19 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion tabVersion added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 1aff757 Nov 7, 2023
8 of 9 checks passed
@tabVersion tabVersion deleted the tab/ref-metric branch November 7, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics partition_input_bytes for data generator source is not recorded.
3 participants