Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): impl ExprRewritable for StreamValues #13217

Merged

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Nov 2, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fixes #13184. Same as batch:

impl ExprRewritable for BatchValues {
fn has_rewritable_expr(&self) -> bool {
true
}
fn rewrite_exprs(&self, r: &mut dyn ExprRewriter) -> PlanRef {
Self::new(
self.logical
.rewrite_exprs(r)
.as_logical_values()
.unwrap()
.clone(),
)
.into()
}
}

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Nov 2, 2023
@xiangjinwu xiangjinwu requested a review from BugenZhao November 2, 2023 09:49
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #13217 (073a8c6) into main (fdfbf53) will increase coverage by 0.00%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #13217   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files        1512     1512           
  Lines      256245   256258   +13     
=======================================
+ Hits       174452   174469   +17     
+ Misses      81793    81789    -4     
Flag Coverage Δ
rust 68.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../frontend/src/optimizer/plan_node/stream_values.rs 57.14% <100.00%> (+12.95%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2023
@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2023
@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 0007064 Nov 2, 2023
6 of 7 checks passed
@xiangjinwu xiangjinwu deleted the fix-13184-optimizer-ExprRewritable-for-StreamValues branch November 2, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: timezone-dependent exprs panic in StreamValues
2 participants