Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): reduce join cache entry size #13214

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Nov 2, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Use Vec instead of BTreeMap when the number of elements is small to save memory usage.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yuhao-su yuhao-su marked this pull request as ready for review November 2, 2023 11:07
@yuhao-su yuhao-su requested a review from a team as a code owner November 2, 2023 11:07
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #13214 (a856beb) into main (73dcbc2) will decrease coverage by 0.08%.
Report is 10 commits behind head on main.
The diff coverage is 71.60%.

@@            Coverage Diff             @@
##             main   #13214      +/-   ##
==========================================
- Coverage   68.14%   68.07%   -0.08%     
==========================================
  Files        1513     1516       +3     
  Lines      256990   257175     +185     
==========================================
- Hits       175135   175069      -66     
- Misses      81855    82106     +251     
Flag Coverage Δ
rust 68.07% <71.60%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/meta/src/backup_restore/utils.rs 43.58% <ø> (ø)
src/storage/backup/src/storage.rs 63.55% <100.00%> (+0.34%) ⬆️
src/storage/src/hummock/backup_reader.rs 31.17% <ø> (ø)
...rc/executor/managed_state/join/join_entry_state.rs 98.91% <100.00%> (+0.52%) ⬆️
src/stream/src/executor/managed_state/join/mod.rs 93.79% <ø> (ø)
src/storage/backup/src/lib.rs 56.81% <66.66%> (-0.33%) ⬇️
...am/src/executor/managed_state/join/join_row_set.rs 75.92% <75.92%> (ø)
src/meta/src/backup_restore/restore.rs 83.33% <63.15%> (-2.45%) ⬇️
src/meta/src/backup_restore/restore_impl/v1.rs 87.87% <87.87%> (ø)
src/meta/src/backup_restore/restore_impl/v2.rs 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@yuhao-su yuhao-su requested a review from stdrc November 3, 2023 05:05
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuhao-su yuhao-su added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit db5481a Nov 3, 2023
11 of 12 checks passed
@yuhao-su yuhao-su deleted the yuhao/reduce_join_cache_entry_size branch November 3, 2023 06:07
yuhao-su added a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants