Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdc): avoid serde the schema field in the Debzium connector #13212

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Nov 2, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #12535 (comment)

The provided JSON converter will output the schema field in the JSON which is unnecessary to source parser, we use a customized JSON converter to avoid outputting the schema field to save cpu.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@StrikeW StrikeW requested review from hzxa21 and tabVersion November 2, 2023 08:49
@github-actions github-actions bot added the type/fix Bug fix label Nov 2, 2023
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the change but why retain the schema field?

@StrikeW
Copy link
Contributor Author

StrikeW commented Nov 2, 2023

I am ok with the change but why retain the schema field?

In #12535 the CREATE SOURCE requires the payload field since its schema has a (payload jsonb) column.

@StrikeW StrikeW enabled auto-merge November 2, 2023 09:03
@StrikeW StrikeW added this pull request to the merge queue Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #13212 (c4dc700) into main (73dcbc2) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13212   +/-   ##
=======================================
  Coverage   68.14%   68.15%           
=======================================
  Files        1513     1513           
  Lines      256990   256990           
=======================================
+ Hits       175135   175139    +4     
+ Misses      81855    81851    -4     
Flag Coverage Δ
rust 68.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 4daf642 Nov 2, 2023
6 of 7 checks passed
@StrikeW StrikeW deleted the siyuan/dbz-connector branch November 2, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants