fix(expr): date_trunc and +/- on timestamptz during DST jump-back
#13201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13201 +/- ##
==========================================
- Coverage 68.07% 68.04% -0.03%
==========================================
Files 1512 1512
Lines 256245 256258 +13
==========================================
- Hits 174441 174380 -61
- Misses 81804 81878 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wangrunji0408
approved these changes
Nov 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
For context,
2023-11-05 01:59:59-07:00is followed by2023-11-05 01:00:00-08:00inUS/Pacific.There are two
2023-11-05 01:40:00in local time, corresponding to UTC time2023-11-05T08:40:00Z(1699173600s since the unix epoch) and2023-11-05T09:40:00Z(1699177200s since the unix epoch).And also two
2023-11-05 01:00:00in local time, corresponding to UTC time2023-11-05T08:00:00Z(1699171200s since the unix epoch) and2023-11-05T09:00:00Z(1699174800s since the unix epoch).Fixes #12072
In short:
date_trunctohourof2023-11-05 01:40:00in Pacific Daylight Time (-07:00) shall return2023-11-05 01:00:00in Pacific Daylight Time, rather than Pacific Standard Time (-08:00).date_trunctomicrosecondsof2023-11-05 08:40:00Zand2023-11-05 09:35:00ZunderUS/Pacificshall return them unchanged, rather than2023-11-05 09:40:00Zand2023-11-05 09:35:00Z(non-monotonic).set timezone = 'US/Pacific','2023-11-05 01:40:00-07:00'::timestamptz + interval '5' minuteshall return2023-11-05 01:45:00-07:00rather than2023-11-05 01:45:00-08:00(which is 65 minutes later).Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.