-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): add jsonb_build_array/object
function
#13198
Conversation
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
cb35a8e
to
be0679f
Compare
jsonb_build_array/object
functionjsonb_build_array/object
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactoring. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #13198 +/- ##
==========================================
- Coverage 68.11% 68.10% -0.01%
==========================================
Files 1517 1518 +1
Lines 257380 257405 +25
==========================================
Hits 175302 175302
- Misses 82078 82103 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Being asked by a user today. Please remember to tag as user-facing. |
Thanks for reminding. I didn't click the checkbox of documentation initially, but clicked it later by editing. Looks like it didn't trigger the bot to automatically add the tag. ( |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry my fault. @wangrunji0408
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
resolve #13016
This PR implements
jsonb_build_array
andjsonb_build_object
function. But theVARIADIC
keyword before arguments are not supported.This PR also adds more data type support for
jsonb_agg
andjsonb_object_agg
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Add
jsonb_build_array
andjsonb_build_object
function:Limitation: calling with
VARIADIC
keyword is not supported yet. e.g.jsonb_agg
now accept any type except array and struct.jsonb_object_agg
now accept any type except array and struct as value. keys are still limited to varchar.