Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): adapt metadata restore to metadata model V2 #13197

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Nov 1, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This is the metadata restore part.

  • Refactor V1 restore code.
  • Implement V2 restore.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #13197 (c5e26bf) into main (73dcbc2) will decrease coverage by 0.02%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##             main   #13197      +/-   ##
==========================================
- Coverage   68.14%   68.13%   -0.02%     
==========================================
  Files        1513     1515       +2     
  Lines      256990   257091     +101     
==========================================
+ Hits       175135   175174      +39     
- Misses      81855    81917      +62     
Flag Coverage Δ
rust 68.13% <65.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/meta/src/backup_restore/utils.rs 43.58% <ø> (ø)
src/storage/backup/src/storage.rs 63.55% <100.00%> (+0.34%) ⬆️
src/storage/src/hummock/backup_reader.rs 31.17% <ø> (ø)
src/storage/backup/src/lib.rs 56.81% <66.66%> (-0.33%) ⬇️
src/meta/src/backup_restore/restore.rs 83.33% <63.15%> (-2.45%) ⬇️
src/meta/src/backup_restore/restore_impl/v1.rs 87.87% <87.87%> (ø)
src/meta/src/backup_restore/restore_impl/v2.rs 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 2, 2023
@zwang28 zwang28 enabled auto-merge November 2, 2023 07:41
@zwang28 zwang28 added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 801582b Nov 2, 2023
8 of 9 checks passed
@zwang28 zwang28 deleted the wangzheng/restore_model_v2 branch November 2, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants