Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): fragment level streaming metrics (part 2) #13196

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Nov 1, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

By default, display all the metrics under "Streaming Actors" section in fragment level.

Close #12381.

Now I keep the actor-level metrics as hidden (see target_hidden()). But for better code readability, shall we just remove it? After all, to check actor-level metrics, simply change the "fragment_id" to "actor_id" on the PromQL query.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

No need.

@fuyufjh fuyufjh force-pushed the eric/fragment_level_metrics_part_2 branch from 300c58a to 3615108 Compare November 2, 2023 06:39
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
more radical, maybe we can remove all the actor-based metrics with #13208?

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #13196 (b45edf8) into main (4daf642) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13196      +/-   ##
==========================================
- Coverage   68.13%   68.13%   -0.01%     
==========================================
  Files        1515     1515              
  Lines      257091   257091              
==========================================
- Hits       175177   175163      -14     
- Misses      81914    81928      +14     
Flag Coverage Δ
rust 68.13% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/stream/src/executor/monitor/streaming_stats.rs 95.69% <100.00%> (ø)
src/stream/src/executor/over_window/general.rs 86.84% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fuyufjh
Copy link
Member Author

fuyufjh commented Nov 2, 2023

LGTM. more radical, maybe we can remove all the actor-based metrics with #13208?

Either LGTM 🥰

Base automatically changed from eric/clean_metrics to main November 2, 2023 10:08
@fuyufjh fuyufjh enabled auto-merge November 2, 2023 10:59
@fuyufjh fuyufjh added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2023
@fuyufjh fuyufjh added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 537bbe2 Nov 2, 2023
6 of 7 checks passed
@fuyufjh fuyufjh deleted the eric/fragment_level_metrics_part_2 branch November 2, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: fragment-level metrics on Grafana dashboard
3 participants