-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): fragment level streaming metrics (part 2) #13196
Conversation
300c58a
to
3615108
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
more radical, maybe we can remove all the actor-based metrics with #13208?
Codecov Report
@@ Coverage Diff @@
## main #13196 +/- ##
==========================================
- Coverage 68.13% 68.13% -0.01%
==========================================
Files 1515 1515
Lines 257091 257091
==========================================
- Hits 175177 175163 -14
- Misses 81914 81928 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Either LGTM 🥰 |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
By default, display all the metrics under "Streaming Actors" section in fragment level.
Close #12381.
Now I keep the actor-level metrics as hidden (see
target_hidden()
). But for better code readability, shall we just remove it? After all, to check actor-level metrics, simply change the "fragment_id" to "actor_id" on the PromQL query.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
No need.