Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hash_agg bench #13193

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix: hash_agg bench #13193

merged 1 commit into from
Nov 1, 2023

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #13181

This line is needed to ensure functions are linked to the binary.

risingwave_expr_impl::enable!();

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Runji Wang <[email protected]>
@github-actions github-actions bot added the type/fix Bug fix label Nov 1, 2023
@kwannoel
Copy link
Contributor

kwannoel commented Nov 1, 2023

LGTM thanks!

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #13193 (172a080) into main (7122d6c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13193   +/-   ##
=======================================
  Coverage   68.10%   68.10%           
=======================================
  Files        1507     1507           
  Lines      255634   255634           
=======================================
+ Hits       174103   174104    +1     
+ Misses      81531    81530    -1     
Flag Coverage Δ
rust 68.10% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 1b65be2 Nov 1, 2023
8 of 9 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/fix-hash-agg-bench branch November 1, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hash_agg microbench failing
2 participants