Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlsmith): use encoded string as input to decode #13191

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Nov 1, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel force-pushed the kwannoel/fix-decode branch from 7700b9b to 6854dec Compare November 1, 2023 03:46
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #13191 (6854dec) into main (84d27ba) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13191      +/-   ##
==========================================
- Coverage   68.23%   68.16%   -0.07%     
==========================================
  Files        1506     1506              
  Lines      255354   255354              
==========================================
- Hits       174235   174058     -177     
- Misses      81119    81296     +177     
Flag Coverage Δ
rust 68.16% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kwannoel kwannoel requested a review from lmatz November 1, 2023 04:40
@kwannoel kwannoel enabled auto-merge November 1, 2023 04:41
@kwannoel kwannoel requested a review from zwang28 November 1, 2023 05:04
@kwannoel kwannoel added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 82c9926 Nov 1, 2023
6 of 7 checks passed
@kwannoel kwannoel deleted the kwannoel/fix-decode branch November 1, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants