Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce user and privilege functions based on sql meta store #13189

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Nov 1, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Part of #12449 . Introduced user and privilege related functions in catalog controller.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yezizp2012 yezizp2012 marked this pull request as ready for review November 1, 2023 09:58
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #13189 (1bde04e) into main (675bdca) will increase coverage by 0.13%.
Report is 7 commits behind head on main.
The diff coverage is 88.17%.

@@            Coverage Diff             @@
##             main   #13189      +/-   ##
==========================================
+ Coverage   68.00%   68.14%   +0.13%     
==========================================
  Files        1511     1512       +1     
  Lines      256092   256837     +745     
==========================================
+ Hits       174156   175015     +859     
+ Misses      81936    81822     -114     
Flag Coverage Δ
rust 68.14% <88.17%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ta/model_v2/migration/src/m20230908_072257_init.rs 99.06% <100.00%> (+0.02%) ⬆️
src/meta/model_v2/src/database.rs 63.63% <100.00%> (ø)
src/meta/model_v2/src/function.rs 91.66% <100.00%> (ø)
src/meta/model_v2/src/view.rs 100.00% <100.00%> (ø)
src/meta/src/controller/cluster.rs 65.62% <100.00%> (ø)
src/meta/src/controller/mod.rs 12.06% <ø> (ø)
src/meta/src/controller/system_param.rs 77.52% <100.00%> (ø)
src/meta/model_v2/src/lib.rs 20.33% <0.00%> (-0.36%) ⬇️
src/meta/model_v2/src/schema.rs 9.09% <0.00%> (ø)
src/meta/model_v2/src/connection.rs 20.00% <0.00%> (ø)
... and 6 more

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@zwang28 zwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

src/meta/src/controller/user.rs Outdated Show resolved Hide resolved
src/meta/src/controller/system_param.rs Show resolved Hide resolved
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/meta/src/controller/utils.rs Show resolved Hide resolved
@yezizp2012 yezizp2012 enabled auto-merge November 2, 2023 05:44
@yezizp2012 yezizp2012 added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 73dcbc2 Nov 2, 2023
6 of 7 checks passed
@yezizp2012 yezizp2012 deleted the feat/sql-user-privilege branch November 2, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants