fix(test): use rate limit instead in background ddl test #13179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
force-pushed
the
kwannoel/use-rate-limit
branch
from
526bec0 to
fd18cd1
Compare
yezizp2012
approved these changes
Oct 31, 2023
kwannoel
changed the title
kwannoel
commented
Oct 31, 2023
ci/scripts/deterministic-it-test.sh
Outdated
| @@ -16,7 +16,6 @@ mv target/ci-sim target/sim | |||
| echo "--- Run integration tests in deterministic simulation mode" | |||
| seq $TEST_NUM | parallel MADSIM_TEST_SEED={} NEXTEST_PROFILE=ci-sim \ | |||
| cargo nextest run \ | |||
| --no-capture \ | |||
There was a problem hiding this comment.
BugenZhao
approved these changes
Oct 31, 2023
chenzl25
approved these changes
Oct 31, 2023
kwannoel
force-pushed
the
kwannoel/use-rate-limit
branch
from
5fccb81 to
ba06539
Compare
kwannoel
force-pushed
the
kwannoel/use-rate-limit
branch
from
ba06539 to
a3c50d1
Compare
Seems like deterministic test failure is triggered by something else... It failed even when all |
|
Temporarily add 2 commits from #13178, so we can see if it resolves the failure. |
Codecov Report
@@ Coverage Diff @@
## main #13179 +/- ##
=======================================
Coverage 68.15% 68.16%
=======================================
Files 1506 1506
Lines 255354 255354
=======================================
+ Hits 174049 174061 +12
+ Misses 81305 81293 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Use rate limit instead. After #13144 , thanks to @wangrunji0408's help, we support rate limit in madsim. Then in cancel tests, it was failing, even with rate limit, because the MV finished creating too fast before it could be cancelled.
So now we just ingest more data when creating the background MV which will be recovered, then cancelled.
We can now remove the env var in
no_shuffle_backfill.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.