Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expr): null input of ~ / !~ #13145

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix(expr): null input of ~ / !~ #13145

merged 2 commits into from
Oct 30, 2023

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fixes #5136

We used to rewrite a ~ b to regexp_match(a, b) is not null in frontend. This works in most cases except when either a or b is null, where the former is expected to return null but the rewritten form returns false. Thanks to prebuild of function macro, we can now support a native ~ implementation without rewriting.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #13145 (cb50793) into main (e392db0) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 54.54%.

@@           Coverage Diff           @@
##             main   #13145   +/-   ##
=======================================
  Coverage   68.24%   68.25%           
=======================================
  Files        1500     1500           
  Lines      252692   252699    +7     
=======================================
+ Hits       172448   172470   +22     
+ Misses      80244    80229   -15     
Flag Coverage Δ
rust 68.25% <54.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/frontend/src/expr/pure.rs 87.69% <ø> (ø)
src/frontend/src/binder/expr/binary_op.rs 71.13% <66.66%> (+0.72%) ⬆️
src/expr/impl/src/scalar/regexp.rs 14.20% <50.00%> (+0.79%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit a9d9bc9 Oct 30, 2023
8 of 9 checks passed
@xiangjinwu xiangjinwu deleted the fix-expr-5136-regexp-op branch October 30, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(expr): regex operator ~ / !~ should return null when either input is null
3 participants