Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(optimizer): remove some ColIndexMapping::without_tar_size usage #13134

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Oct 30, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #13100

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #13134 (8c63e3e) into main (9a5e2b8) will decrease coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is 42.28%.

@@            Coverage Diff             @@
##             main   #13134      +/-   ##
==========================================
- Coverage   68.27%   68.25%   -0.03%     
==========================================
  Files        1499     1500       +1     
  Lines      252602   252687      +85     
==========================================
+ Hits       172459   172461       +2     
- Misses      80143    80226      +83     
Flag Coverage Δ
rust 68.25% <42.28%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/src/util/column_index_mapping.rs 73.83% <100.00%> (-0.72%) ⬇️
src/frontend/src/binder/expr/function.rs 78.63% <100.00%> (+0.09%) ⬆️
src/frontend/src/expr/pure.rs 87.69% <ø> (ø)
src/frontend/src/handler/alter_table_column.rs 69.29% <100.00%> (ø)
...ntend/src/optimizer/plan_node/eq_join_predicate.rs 85.05% <100.00%> (ø)
...c/frontend/src/optimizer/plan_node/generic/join.rs 95.72% <100.00%> (ø)
...rontend/src/optimizer/plan_node/generic/project.rs 99.50% <100.00%> (ø)
...end/src/optimizer/plan_node/generic/project_set.rs 100.00% <100.00%> (ø)
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 96.93% <100.00%> (ø)
...frontend/src/optimizer/plan_node/logical_expand.rs 100.00% <100.00%> (ø)
... and 19 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st1page st1page added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 67056a5 Oct 30, 2023
6 of 7 checks passed
@st1page st1page deleted the sts/remove_some_without_tar_size branch October 30, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColIndexMapping::without_target_size is error-prone
3 participants