Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expr): include data type in parse error message #13121

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Oct 29, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolves #11059

dev=> insert into sales values (1, '{name: "Alice", paying: true, tags: ["admin"]}');
ERROR:  QueryError: Expr error: Parse error: jsonb key must be a string at line 1 column 2

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #13121 (86f88c9) into main (23b69c4) will decrease coverage by 0.02%.
Report is 16 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13121      +/-   ##
==========================================
- Coverage   68.22%   68.21%   -0.02%     
==========================================
  Files        1501     1501              
  Lines      252773   252777       +4     
==========================================
- Hits       172464   172425      -39     
- Misses      80309    80352      +43     
Flag Coverage Δ
rust 68.21% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/expr/impl/src/scalar/cast.rs 84.73% <100.00%> (+0.10%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 29, 2023
Merged via the queue into main with commit 8cbe568 Oct 29, 2023
6 of 7 checks passed
@xiangjinwu xiangjinwu deleted the fix-11059-expr-parse-err branch October 29, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify JSONB insert bug
2 participants