-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(object store): bump OpenDAL to v0.41 #13101
Conversation
src/object_store/src/object/opendal_engine/opendal_object_store.rs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #13101 +/- ##
==========================================
- Coverage 68.29% 68.22% -0.07%
==========================================
Files 1501 1501
Lines 252750 252714 -36
==========================================
- Hits 172623 172426 -197
- Misses 80127 80288 +161
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM!
@zwang28 PTAL, I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
https://opendal.apache.org/docs/rust/opendal/docs/upgrade/index.html
Some break changes.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.