fix(ci): fix iceberg-cdc integration_tests #13082
Conversation
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 7648795 | Generic CLI Secret | a6148b4 | integration_tests/iceberg-cdc/docker-compose.yml | View secret |
| 7648795 | Generic CLI Secret | a6148b4 | integration_tests/iceberg-cdc/run_test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Could you please remove the password from iceberg-cdc run_test.sh? |
| @@ -0,0 +1,18 @@ | |||
| # 使用 Python 3.8 作为基础镜像 | |||
There was a problem hiding this comment.
Remove the comments as well
|
Could you include the buildkite job link in the pr description as well? I mean the job link for this PR. You need to check if this PR works as expected. |
| @@ -2,7 +2,7 @@ version: '3.8' | |||
|
|
|||
| services: | |||
| compactor-0: | |||
| extends: | |||
| extends: | |||
There was a problem hiding this comment.
seems a space is missing
|
LGTM, as @neverchanje says, please have a try with buildkite before merging. |
ZENOTME
force-pushed
the
zj/cdc
branch
3 times, most recently
from
c31c06c to
59396f8
Compare
Codecov Report
@@ Coverage Diff @@
## main #13082 +/- ##
==========================================
+ Coverage 68.25% 68.31% +0.05%
==========================================
Files 1498 1498
Lines 252749 252749
==========================================
+ Hits 172514 172664 +150
+ Misses 80235 80085 -150
Flags with carried forward coverage won't be shown. Click here to find out more. see 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Move python check to docker.
fix: https://buildkite.com/risingwavelabs/integration-tests/builds/316#018b6723-fddd-4243-a107-d3d56cacd716
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.