Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): support int8send and int8recv #13077

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Oct 26, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Only supports int8 right now. After ToBinary and FromBinary refactor, all types can be supported.

int8recv is not callable in PostgreSQL, but can be useful to decode a bytea into a bigint. Resolves #13069

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

These functions are relatively stable in PostgreSQL, but still unsure whether they should be documented given its naming.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #13077 (d156d06) into main (4a8b0cb) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 47.82%.

@@            Coverage Diff             @@
##             main   #13077      +/-   ##
==========================================
- Coverage   68.27%   68.21%   -0.07%     
==========================================
  Files        1501     1501              
  Lines      252750   252773      +23     
==========================================
- Hits       172576   172422     -154     
- Misses      80174    80351     +177     
Flag Coverage Δ
rust 68.21% <47.82%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/frontend/src/expr/pure.rs 87.69% <ø> (ø)
src/frontend/src/binder/expr/function.rs 78.51% <84.61%> (+0.06%) ⬆️
src/expr/impl/src/scalar/cast.rs 84.62% <0.00%> (-1.53%) ⬇️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu requested a review from lmatz October 26, 2023 11:23
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2023
@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2023
@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 27, 2023
Merged via the queue into main with commit 23b69c4 Oct 27, 2023
10 of 11 checks passed
@xiangjinwu xiangjinwu deleted the feat-expr-pgwire-bin-int8 branch October 27, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

int8recv and substring(bytea) for correctness checking
2 participants