Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sink): use new format ... encode ... syntax #13066

Closed
wants to merge 1 commit into from

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Seems there are no tests for kinesis at all.
  • We may need to duplicate kafka & plusar tests for both old and new syntax, but I am concerned about doubling test time.
    • This PR is unfinished. e2e_test/sink/kafka/create_sink.slt is still all old, while e2e_test/sink/pulsar_sink.slt is all new.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the component/test Test related issue. label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #13066 (a42ccf1) into main (90fb4a3) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #13066   +/-   ##
=======================================
  Coverage   68.34%   68.34%           
=======================================
  Files        1496     1496           
  Lines      252049   252049           
=======================================
+ Hits       172251   172252    +1     
+ Misses      79798    79797    -1     
Flag Coverage Δ
rust 68.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tabVersion
Copy link
Contributor

Seems there are no tests for kinesis at all.

we need localstack for local testing https://github.com/risingwavelabs/risingwave/tree/main/integration_tests/kinesis-s3-source

Copy link
Contributor

github-actions bot commented Jan 2, 2024

This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants