Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sqlparser): rename SourceSchemaV2/SinkSchema to ConnectorSchema #13065

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

SinkSchema was introduced as a standalone struct to ease review of #12556.

Also removes SourceSchemaV2::gen_options, which is same as WithOptions::try_from.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please check the conflict if it exists @yuhao-su

@xiangjinwu xiangjinwu enabled auto-merge October 26, 2023 06:17
@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #13065 (ce9778d) into main (90fb4a3) will decrease coverage by 0.01%.
Report is 6 commits behind head on main.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main   #13065      +/-   ##
==========================================
- Coverage   68.34%   68.34%   -0.01%     
==========================================
  Files        1496     1496              
  Lines      252049   252016      -33     
==========================================
- Hits       172251   172228      -23     
+ Misses      79798    79788      -10     
Flag Coverage Δ
rust 68.34% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/frontend/src/handler/create_source.rs 49.32% <100.00%> (+0.05%) ⬆️
src/frontend/src/handler/create_table.rs 84.29% <100.00%> (ø)
src/frontend/src/handler/create_sink.rs 66.66% <0.00%> (ø)
src/frontend/src/handler/alter_table_column.rs 69.29% <0.00%> (ø)
src/sqlparser/src/ast/statement.rs 53.31% <69.23%> (-1.38%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2023
@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit 41d2bbd Oct 26, 2023
6 of 7 checks passed
@xiangjinwu xiangjinwu deleted the refactor-sqlparser-source-sink-format branch October 26, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants