-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compactor): collect metrics for fast compact runer #13064
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
commit 4f1e3f9 Author: Little-Wallace <[email protected]> Date: Thu Oct 26 11:37:53 2023 +0800 fix check Signed-off-by: Little-Wallace <[email protected]> commit 1438d7c Merge: de7f2a5 2d428b1 Author: Wallace <[email protected]> Date: Wed Oct 25 14:06:26 2023 +0800 Merge branch 'main' into fix-statistic commit de7f2a5 Merge: 77b0ae1 272eff4 Author: Wallace <[email protected]> Date: Wed Oct 25 11:37:05 2023 +0800 Merge branch 'main' into fix-statistic commit 77b0ae1 Author: Little-Wallace <[email protected]> Date: Wed Oct 18 14:51:08 2023 +0800 collect metrics for fast compact Signed-off-by: Little-Wallace <[email protected]> Signed-off-by: Little-Wallace <[email protected]>
4f1e3f9
to
6239cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, PTAL @zwang28
Codecov Report
@@ Coverage Diff @@
## main #13064 +/- ##
==========================================
- Coverage 68.40% 68.32% -0.08%
==========================================
Files 1496 1496
Lines 252049 252096 +47
==========================================
- Hits 172413 172254 -159
- Misses 79636 79842 +206
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In passed implementation, we do not record drop key size for fast compaction algorithm, it will cause the table size calculated by meta-node less than sum of uncompressed size of all files.
close #12926
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.