Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compactor): collect metrics for fast compact runer #13064

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Oct 26, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In passed implementation, we do not record drop key size for fast compaction algorithm, it will cause the table size calculated by meta-node less than sum of uncompressed size of all files.

close #12926

Checklist

  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@gitguardian
Copy link

gitguardian bot commented Oct 26, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

commit 4f1e3f9
Author: Little-Wallace <[email protected]>
Date:   Thu Oct 26 11:37:53 2023 +0800

    fix check

    Signed-off-by: Little-Wallace <[email protected]>

commit 1438d7c
Merge: de7f2a5 2d428b1
Author: Wallace <[email protected]>
Date:   Wed Oct 25 14:06:26 2023 +0800

    Merge branch 'main' into fix-statistic

commit de7f2a5
Merge: 77b0ae1 272eff4
Author: Wallace <[email protected]>
Date:   Wed Oct 25 11:37:05 2023 +0800

    Merge branch 'main' into fix-statistic

commit 77b0ae1
Author: Little-Wallace <[email protected]>
Date:   Wed Oct 18 14:51:08 2023 +0800

    collect metrics for fast compact

    Signed-off-by: Little-Wallace <[email protected]>

Signed-off-by: Little-Wallace <[email protected]>
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, PTAL @zwang28

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #13064 (04c8383) into main (b724be7) will decrease coverage by 0.08%.
Report is 2 commits behind head on main.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##             main   #13064      +/-   ##
==========================================
- Coverage   68.40%   68.32%   -0.08%     
==========================================
  Files        1496     1496              
  Lines      252049   252096      +47     
==========================================
- Hits       172413   172254     -159     
- Misses      79636    79842     +206     
Flag Coverage Δ
rust 68.32% <90.32%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/storage/hummock_test/src/compactor_tests.rs 96.07% <100.00%> (-0.02%) ⬇️
src/storage/src/hummock/utils.rs 79.52% <ø> (ø)
.../storage/src/hummock/compactor/compactor_runner.rs 81.58% <0.00%> (-0.26%) ⬇️
...age/src/hummock/compactor/fast_compactor_runner.rs 92.34% <93.10%> (+0.24%) ⬆️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Little-Wallace Little-Wallace added this pull request to the merge queue Oct 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2023
@Little-Wallace Little-Wallace added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit 71851d6 Oct 26, 2023
13 checks passed
@Little-Wallace Little-Wallace deleted the fix-statistic branch October 26, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: fast compaction should maintain table stats like normal compaction
2 participants