Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): adapt to foyer new write model #13059

Merged
merged 16 commits into from
Nov 3, 2023
Merged

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Oct 25, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Update foyer and change configs to adapt to the new write model.

foyer-rs/foyer#184

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx self-assigned this Oct 25, 2023
@MrCroxx MrCroxx changed the title storage(filecache): adapt to foyer new write model feat(filecache): adapt to foyer new write model Oct 25, 2023
@gitguardian
Copy link

gitguardian bot commented Oct 31, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7648795 Generic CLI Secret 630daf3 integration_tests/iceberg-cdc/docker-compose.yml View secret
7648795 Generic CLI Secret 630daf3 integration_tests/iceberg-cdc/run_test.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also include the bench result mentioned in the meeting in the comment?

@MrCroxx MrCroxx changed the title feat(filecache): adapt to foyer new write model feat(storage): adapt to foyer new write model Nov 2, 2023
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Nov 2, 2023

Successful insert tail latency comparison:

PR vs main

image

@MrCroxx MrCroxx marked this pull request as ready for review November 3, 2023 08:08
@MrCroxx MrCroxx requested a review from a team as a code owner November 3, 2023 08:08
@MrCroxx MrCroxx enabled auto-merge November 3, 2023 08:15
@MrCroxx MrCroxx requested a review from wangrunji0408 November 3, 2023 08:27
@MrCroxx MrCroxx added this pull request to the merge queue Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #13059 (14e4c9c) into main (31bf68e) will decrease coverage by 0.07%.
Report is 2 commits behind head on main.
The diff coverage is 58.46%.

@@            Coverage Diff             @@
##             main   #13059      +/-   ##
==========================================
- Coverage   68.10%   68.04%   -0.07%     
==========================================
  Files        1517     1517              
  Lines      257380   257358      -22     
==========================================
- Hits       175295   175111     -184     
- Misses      82085    82247     +162     
Flag Coverage Δ
rust 68.04% <58.46%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/src/config.rs 84.31% <100.00%> (-0.32%) ⬇️
src/compute/src/memory_management/mod.rs 81.81% <100.00%> (-1.62%) ⬇️
src/storage/src/opts.rs 99.08% <100.00%> (+0.03%) ⬆️
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/storage/src/hummock/file_cache/store.rs 40.83% <0.00%> (+0.33%) ⬆️
src/storage/src/store_impl.rs 5.92% <0.00%> (-0.03%) ⬇️

... and 21 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Merged via the queue into main with commit e71037d Nov 3, 2023
6 of 8 checks passed
@MrCroxx MrCroxx deleted the xx/foyer-write-model branch November 3, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants