-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): support jsonb @>
, <@
, ?
, ?|
and ?&
operator
#13056
Conversation
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #13056 +/- ##
==========================================
- Coverage 68.27% 68.25% -0.03%
==========================================
Files 1499 1500 +1
Lines 252602 252691 +89
==========================================
+ Hits 172459 172467 +8
- Misses 80143 80224 +81
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -164,6 +164,16 @@ pub enum Token { | |||
HashArrow, | |||
/// `#>>`, extract JSON sub-object at the specified path as text in PostgreSQL | |||
HashLongArrow, | |||
/// `@>`, does the left JSON value contain the right JSON path/value entries at the top level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fyi since you may be interested:
To align with PostgreSQL user-defined operator, these builtin pg-specific operators can also be refactored to be recognized in binder with a lookup table (pg_operator
). so that there is no need to modified tokenizer + parser for each operator. The tokenizing rule is actually this.
It seems to be an overkill right now, so I am not giving it a high priority.
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
7648795 | Generic CLI Secret | 5b164e8 | integration_tests/iceberg-cdc/docker-compose.yml | View secret |
7648795 | Generic CLI Secret | 5b164e8 | integration_tests/iceberg-cdc/run_test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Support jsonb operators: