-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): add jsonb_object
function
#13036
Conversation
b02635c
to
12b1d30
Compare
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
12b1d30
to
b322c09
Compare
Signed-off-by: Runji Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #13036 +/- ##
==========================================
- Coverage 68.26% 68.24% -0.02%
==========================================
Files 1498 1499 +1
Lines 252574 252650 +76
==========================================
+ Hits 172411 172421 +10
- Misses 80163 80229 +66
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
@xiangjinwu By the way, do we plan to be consistent with postgres on array types? i.e. ignore multi-dimensions in the type declaration. In postgres, both one dimension and two dimension input share the same signature |
Signed-off-by: Runji Wang <[email protected]>
No. And in this case, separating |
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 This function lacks the sqllogictests. |
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
Due to the bug in parsing array literals, some test cases are not enabled.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Support the following functions:
Reference: https://www.postgresql.org/docs/16/functions-json.html#FUNCTIONS-JSON-CREATION-TABLE